1
0
mirror of http://git.whoc.org.uk/git/password-manager.git synced 2025-10-25 17:47:34 +02:00

Fixed Dev backend simulated network behaviour and minor code cleanup

This commit is contained in:
Dario Chiappetta
2015-11-25 11:42:18 +01:00
parent 8b7a438039
commit 0abd559e81
5 changed files with 23 additions and 42 deletions

View File

@@ -102,7 +102,6 @@ Clipperz.Base.extend(Clipperz.PM.Proxy.JSON, Clipperz.PM.Proxy, {
//-------------------------------------------------------------------------
// TODO: test
'_uploadAttachment': function(someArguments, aProgressCallback, aSharedSecret, aToll) {
var formData;
var deferredResult;
@@ -142,7 +141,6 @@ Clipperz.Base.extend(Clipperz.PM.Proxy.JSON, Clipperz.PM.Proxy, {
throw someValues['message'];
}
// TODO: check return value with actual request. Expected: ArrayBuffer
return someValues;
});
@@ -151,7 +149,6 @@ Clipperz.Base.extend(Clipperz.PM.Proxy.JSON, Clipperz.PM.Proxy, {
return deferredResult;
},
// TODO: test
'_downloadAttachment': function(someArguments, aProgressCallback, aSharedSecret, aToll) {
var deferredResult;
var parameters;

View File

@@ -281,6 +281,11 @@ Clipperz.Base.extend(Clipperz.PM.Proxy.Offline.DataStore, Object, {
uploadAttachment: function(someArguments, aProgressCallback, aSharedSecret, aToll) {
var connection = this.currentStaticConnection();
var attachmentReference = someArguments['attachmentReference'];
var payloadSize = someArguments['arrayBufferData'].length;
var resultValue = {
result: {},
toll: this.getTollForRequestType('MESSAGE')
};
if (this.isReadOnly() == false) {
connection['userData']['attachments'][attachmentReference] = {
@@ -290,27 +295,31 @@ Clipperz.Base.extend(Clipperz.PM.Proxy.Offline.DataStore, Object, {
'version': someArguments['version'],
};
return this.simulateNetworkDelayResponse(someArguments['arrayBufferData'].length, aProgressCallback, {
result: {},
toll: this.getTollForRequestType('MESSAGE')
});
return Clipperz.Async.callbacks("Proxy.Offline.DataStore.uploadAttachment", [
MochiKit.Base.method(this, 'simulateNetworkDelay', payloadSize, aProgressCallback, resultValue),
function () { return resultValue; },
], {trace:false});
} else {
throw Clipperz.PM.Proxy.Offline.DataStore.exception.ReadOnly;
}
},
downloadAttachment: function(someArguments, aProgressCallback, aSharedSecret, aToll) {
var connection = this.currentStaticConnection();
var reference = someArguments['reference'];
var result = connection['userData']['attachments'][reference]['data'];
var connection = this.currentStaticConnection();
var reference = someArguments['reference'];
var resultData = connection['userData']['attachments'][reference]['data'];
var resultValue = {
result: resultData,
// toll: this.getTollForRequestType('MESSAGE')
};
return this.simulateNetworkDelayResponse(result.length, aProgressCallback, {
result: result,
// toll: this.getTollForRequestType('MESSAGE')
});
return Clipperz.Async.callbacks("Proxy.Offline.DataStore.downloadAttachment", [
MochiKit.Base.method(this, 'simulateNetworkDelay', resultData.length, aProgressCallback, resultValue),
function () { return resultValue; },
], {trace:false});
},
simulateNetworkDelayResponse: function(payloadSize, progressCallback, aResponse) {
simulateNetworkDelay: function(payloadSize, progressCallback) {
var deferredResult;
var i;
@@ -322,8 +331,6 @@ Clipperz.Base.extend(Clipperz.PM.Proxy.Offline.DataStore, Object, {
deferredResult.addMethod(this, 'runProgressCallback', progressCallback, loaded, payloadSize);
}
deferredResult.addCallback(MochiKit.Async.succeed, aResponse);
deferredResult.callback();
return deferredResult;