Bernhard.Linz/openvpn-install
1
0
Fork 0
mirror of https://github.com/angristan/openvpn-install.git synced 2025-12-29 22:27:03 +01:00
Code Issues Projects Releases Wiki Activity

refactor: address Copilot review feedback

Browse Source 
- Remove redundant --days param (EASYRSA_CERT_EXPIRE is sufficient)
- Use writeClientConfig for proper file handling during server renewal
This commit is contained in:
Stanislas Lange
2025-12-29 11:30:05 +01:00
parent 3ed7237aac
commit 1bbf6cc1f7
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
openvpn-install.sh
View File

@@ -4128,7 +4128,7 @@ function renewClient() {
run_cmd "Removing old request" rm -f "pki/reqs/$CLIENT.req" run_cmd "Removing old request" rm -f "pki/reqs/$CLIENT.req"
# Generate new self-signed certificate # Generate new self-signed certificate
run_cmd_fatal "Generating new certificate" ./easyrsa --batch --days="$client_cert_duration_days" self-sign-client "$CLIENT" nopass run_cmd_fatal "Generating new certificate" ./easyrsa --batch self-sign-client "$CLIENT" nopass
# Extract new fingerprint # Extract new fingerprint
local new_fingerprint local new_fingerprint
@@ -4231,7 +4231,7 @@ function renewServer() {
# Generate new self-signed server certificate # Generate new self-signed server certificate
export EASYRSA_CERT_EXPIRE=$server_cert_duration_days export EASYRSA_CERT_EXPIRE=$server_cert_duration_days
run_cmd_fatal "Generating new server certificate" ./easyrsa --batch --days="$server_cert_duration_days" self-sign-server "$server_name" nopass run_cmd_fatal "Generating new server certificate" ./easyrsa --batch self-sign-server "$server_name" nopass
# Extract the new fingerprint # Extract the new fingerprint
local new_fingerprint local new_fingerprint
@@ -4256,9 +4256,8 @@ function renewServer() {
if [[ -n "$clients" ]]; then if [[ -n "$clients" ]]; then
while IFS= read -r client; do while IFS= read -r client; do
if [[ -n "$client" ]] && [[ -f "pki/issued/$client.crt" ]]; then if [[ -n "$client" ]] && [[ -f "pki/issued/$client.crt" ]]; then
local client_config_path="$HOME/$client.ovpn"
log_info "Regenerating config for client: $client" log_info "Regenerating config for client: $client"
generateClientConfig "$client" "$client_config_path" CLIENT="$client" writeClientConfig "$client"
fi fi
done <<<"$clients" done <<<"$clients"
fi fi