clipperz/password-manager
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fixed SRP check for negative values

Browse Source
This commit is contained in:
Giulio Cesare Solaroli 2015-02-16 18:20:49 +01:00
parent acb72cc1e0
commit 2a614c8946
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/beta/js/Clipperz/Crypto/SRP.js
View File

@ -151,7 +151,8 @@ Clipperz.Crypto.SRP.Connection.prototype = MochiKit.Base.update(null, {
if (this._A == null) { if (this._A == null) {
// Warning: this value should be strictly greater than zero // Warning: this value should be strictly greater than zero
this._A = Clipperz.Crypto.SRP.g().powerModule(this.a(), Clipperz.Crypto.SRP.n()); this._A = Clipperz.Crypto.SRP.g().powerModule(this.a(), Clipperz.Crypto.SRP.n());
if (this._A.equals(0) || negative(this._A)) { // if (this._A.equals(0) || negative(this._A)) {
if (this._A.compare(Clipperz.Crypto.BigInt.ZERO) <= 0) {
MochiKit.Logging.logError("Clipperz.Crypto.SRP.Connection: trying to set 'A' to 0."); MochiKit.Logging.logError("Clipperz.Crypto.SRP.Connection: trying to set 'A' to 0.");
throw Clipperz.Crypto.SRP.exception.InvalidValue; throw Clipperz.Crypto.SRP.exception.InvalidValue;
} }
@ -179,7 +180,8 @@ Clipperz.Crypto.SRP.Connection.prototype = MochiKit.Base.update(null, {
'set_B': function(aValue) { 'set_B': function(aValue) {
// Warning: this value should be strictly greater than zero // Warning: this value should be strictly greater than zero
this._B = aValue; this._B = aValue;
if (this._B.equals(0) || negative(this._B)) { // if (this._B.equals(0) || negative(this._B)) {
if (this._B.compare(Clipperz.Crypto.BigInt.ZERO) <= 0) {
MochiKit.Logging.logError("Clipperz.Crypto.SRP.Connection: trying to set 'B' to 0."); MochiKit.Logging.logError("Clipperz.Crypto.SRP.Connection: trying to set 'B' to 0.");
throw Clipperz.Crypto.SRP.exception.InvalidValue; throw Clipperz.Crypto.SRP.exception.InvalidValue;
} }

6
frontend/delta/js/Clipperz/Crypto/SRP.js
View File

@ -153,7 +153,8 @@ Clipperz.Crypto.SRP.Connection.prototype = MochiKit.Base.update(null, {
if (this._A == null) { if (this._A == null) {
// Warning: this value should be strictly greater than zero // Warning: this value should be strictly greater than zero
this._A = Clipperz.Crypto.SRP.g().powerModule(this.a(), Clipperz.Crypto.SRP.n()); this._A = Clipperz.Crypto.SRP.g().powerModule(this.a(), Clipperz.Crypto.SRP.n());
if (this._A.equals(0) || negative(this._A)) { // if (this._A.equals(0) || negative(this._A)) {
if (this._A.compare(Clipperz.Crypto.BigInt.ZERO) <= 0) {
Clipperz.logError("Clipperz.Crypto.SRP.Connection: trying to set 'A' to 0."); Clipperz.logError("Clipperz.Crypto.SRP.Connection: trying to set 'A' to 0.");
throw Clipperz.Crypto.SRP.exception.InvalidValue; throw Clipperz.Crypto.SRP.exception.InvalidValue;
} }
@ -181,7 +182,8 @@ Clipperz.Crypto.SRP.Connection.prototype = MochiKit.Base.update(null, {
'set_B': function(aValue) { 'set_B': function(aValue) {
// Warning: this value should be strictly greater than zero // Warning: this value should be strictly greater than zero
this._B = aValue; this._B = aValue;
if (this._B.equals(0) || negative(this._B)) { // if (this._B.equals(0) || negative(this._B)) {
if (this._B.compare(Clipperz.Crypto.BigInt.ZERO) <= 0) {
Clipperz.logError("Clipperz.Crypto.SRP.Connection: trying to set 'B' to 0."); Clipperz.logError("Clipperz.Crypto.SRP.Connection: trying to set 'B' to 0.");
throw Clipperz.Crypto.SRP.exception.InvalidValue; throw Clipperz.Crypto.SRP.exception.InvalidValue;
} }

6
frontend/gamma/js/Clipperz/Crypto/SRP.js
View File

@ -151,7 +151,8 @@ Clipperz.Crypto.SRP.Connection.prototype = MochiKit.Base.update(null, {
if (this._A == null) { if (this._A == null) {
// Warning: this value should be strictly greater than zero // Warning: this value should be strictly greater than zero
this._A = Clipperz.Crypto.SRP.g().powerModule(this.a(), Clipperz.Crypto.SRP.n()); this._A = Clipperz.Crypto.SRP.g().powerModule(this.a(), Clipperz.Crypto.SRP.n());
if (this._A.equals(0) || negative(this._A)) { // if (this._A.equals(0) || negative(this._A)) {
if (this._A.compare(Clipperz.Crypto.BigInt.ZERO) <= 0) {
Clipperz.logError("Clipperz.Crypto.SRP.Connection: trying to set 'A' to 0."); Clipperz.logError("Clipperz.Crypto.SRP.Connection: trying to set 'A' to 0.");
throw Clipperz.Crypto.SRP.exception.InvalidValue; throw Clipperz.Crypto.SRP.exception.InvalidValue;
} }
@ -179,7 +180,8 @@ Clipperz.Crypto.SRP.Connection.prototype = MochiKit.Base.update(null, {
'set_B': function(aValue) { 'set_B': function(aValue) {
// Warning: this value should be strictly greater than zero // Warning: this value should be strictly greater than zero
this._B = aValue; this._B = aValue;
if (this._B.equals(0) || negative(this._B)) { // if (this._B.equals(0) || negative(this._B)) {
if (this._B.compare(Clipperz.Crypto.BigInt.ZERO) <= 0) {
Clipperz.logError("Clipperz.Crypto.SRP.Connection: trying to set 'B' to 0."); Clipperz.logError("Clipperz.Crypto.SRP.Connection: trying to set 'B' to 0.");
throw Clipperz.Crypto.SRP.exception.InvalidValue; throw Clipperz.Crypto.SRP.exception.InvalidValue;
} }